A blog about snakes, dinosaurs and unicorns

Marking diffs as reviewed on mozreview

Like other code review tools out there, MozReview now allows you to mark a single diff as reviewed. A new button has been added to the top-right corner of each diff. This button, initially grey and labelled ‘not reviewed’, will turn green when clicked and its label will switch to ‘reviewed’.

Here is an example of a diff not yet reviewed

and here is how it looks like when you click on the not reviewed button

The ability to mark diffs as reviewed opens new possibilities up:

  • display a counter of files yet to be review (bug 1233597)
  • add a ‘what’s next to review’ link that the user can click to go the the next yet to be reviewed diff (bug 1242457)
  • let the user opt-in to give a direct ship-it when all the diffs in a commit are reviewed and there are no open issues (bug 1237634)

If you think one of those features would really make you more productive please let us know on the mozreview irc channel or twitter so that we can prioritize it accordingly

If you liked this post, you can share it with your followers or follow me on Twitter!
comments powered by Disqus